Skip to content

Migrate dotnet to 10, corelib to v10 and improve integration tests#73

Merged
Dragemil merged 11 commits intomainfrom
task/migrate-to-dotnet-and-corelib-10
Dec 10, 2025
Merged

Migrate dotnet to 10, corelib to v10 and improve integration tests#73
Dragemil merged 11 commits intomainfrom
task/migrate-to-dotnet-and-corelib-10

Conversation

@Dragemil
Copy link
Copy Markdown
Collaborator

@Dragemil Dragemil commented Dec 8, 2025

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 8, 2025

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 48d70d6.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the LeanPipe publisher project from .NET 9 to .NET 10, updates the LeanCode CoreLib dependency to version 10.0.2750-preview, and significantly improves the integration test infrastructure with better tooling and documentation.

Key Changes:

  • Upgraded .NET runtime from 9.0 to 10.0 across all projects, Docker images, and CI/CD workflows
  • Updated CoreLib packages to v10.0.2750-preview and related dependencies (MassTransit 8.5.7, test SDK 18.0.1)
  • Added comprehensive test automation scripts and documentation for Kubernetes-based integration tests

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
publisher/Directory.Build.props Updated target framework to net10.0 and copyright year to 2025
publisher/Directory.Packages.props Updated CoreLib to 10.0.2750-preview, MassTransit to 8.5.7, and test packages to latest versions
publisher/global.json Removed SDK version pinning (was pinned to 9.0.100)
publisher/test/Directory.Build.props Added build configuration to suppress warnings CA1515 and CS7022 for test projects
publisher/src/LeanCode.Pipe/LeanCode.Pipe.csproj Updated logging package from LeanCode.Logging to LeanCode.Logging.AspNetCore
publisher/src/LeanCode.Pipe/LeanPipeServiceCollectionExtensions.cs Modernized service registration using generic overload
publisher/src/LeanCode.Pipe/Funnel/Instance/ServiceCollectionExtensions.cs Modernized service registration using generic overload
publisher/src/LeanCode.Pipe/Funnel/FunnelledService/RegistrationConfiguratorExtensions.cs Added hostname to queue InstanceId for RabbitMQ scaling and modernized HasInterface call
publisher/test/LeanCode.Pipe.Tests/SubscriptionHandlerWrapperTests.cs Modernized FluentAssertions assertion using generic Be() method
publisher/test/LeanCode.Pipe.IntegrationTests/LeanCode.Pipe.IntegrationTests.csproj Removed System.Linq.Async package reference
publisher/test/LeanCode.Pipe.IntegrationTests/App/Program.cs Updated to use ConfigureDefaultLogging from LeanCode.Logging.AspNetCore
publisher/test/LeanCode.Pipe.Funnel.TestAppFunnel/Program.cs Added LeanCode.Logging.AspNetCore using statement
publisher/test/LeanCode.Pipe.Funnel.TestApp1/Program.cs Added LeanCode.Logging.AspNetCore using statement
publisher/test/LeanCode.Pipe.Funnel.TestApp2/Program.cs Added LeanCode.Logging.AspNetCore using statement
publisher/test/LeanCode.Pipe.ClientIntegrationTestsApp/Program.cs Added LeanCode.Logging.AspNetCore using statement
publisher/funnel_test_cluster/*.dockerfile Updated all Docker base images from dotnet/aspnet:9.0 to 10.0
publisher/funnel_test_cluster/run-tests.sh Added comprehensive automation script for running Kubernetes integration tests
publisher/funnel_test_cluster/README.md Added detailed documentation for funnel scaling tests
publisher/client_integration_tests_cluster/testapp.dockerfile Updated Docker base image to dotnet/aspnet:10.0
publisher/client_integration_tests_cluster/README.md Added comprehensive documentation for client integration test cluster
.github/workflows/publisher_ci.yml Updated to .NET 10.0 and latest GitHub Actions (checkout@v6, setup-dotnet@v5, upload-artifact@v5, download-artifact@v6)
.github/workflows/publisher_release.yml Updated to .NET 10.0 and latest GitHub Actions (checkout@v6, setup-dotnet@v5)
.github/workflows/funnel_msvc_tests.yml Updated to .NET 10.0, latest actions, added concurrency control and failure log collection
.github/workflows/dart_integration_tests.yml Updated to .NET 10.0, latest actions, added concurrency control and failure log collection

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread publisher/funnel_test_cluster/run-tests.sh Outdated
Comment thread publisher/test/Directory.Build.props Outdated
@Dragemil Dragemil requested a review from mishioo December 8, 2025 12:39
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 8, 2025

Publisher Unit Test Results

 4 files   4 suites   22s ⏱️
55 tests 55 ✅ 0 💤 0 ❌
69 runs  69 ✅ 0 💤 0 ❌

Results for commit 6f06bfc.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Collaborator

@mishioo mishioo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More or less nitpicks

Comment thread publisher/client_integration_tests_cluster/README.md
Comment thread publisher/funnel_test_cluster/README.md
Comment thread publisher/funnel_test_cluster/README.md
Comment thread publisher/funnel_test_cluster/README.md
@Dragemil Dragemil merged commit 4bc6afd into main Dec 10, 2025
5 checks passed
@Dragemil Dragemil deleted the task/migrate-to-dotnet-and-corelib-10 branch December 10, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants