Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps the CSharpier code formatter from version 0.26.2 to 1.2.1 and reformats the entire codebase according to the new formatter's rules. The update includes changes to the tool configuration, CI workflow command, and a .git-blame-ignore-revs entry to exclude this formatting commit from blame history.
Key Changes:
- Updated CSharpier from version 0.26.2 to 1.2.1 with
rollForward: falsesetting - Modified CI workflow to use the new
dotnet tool run csharpier check .command syntax - Added commit hash to .git-blame-ignore-revs to exclude formatting changes from git blame
- Reformatted all C# and project files according to CSharpier 1.2.1 rules
Reviewed changes
Copilot reviewed 48 out of 50 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| publisher/.config/dotnet-tools.json | Updated CSharpier version to 1.2.1, changed command name, and added rollForward setting |
| .github/workflows/publisher_ci.yml | Updated formatting check command to new syntax |
| .git-blame-ignore-revs | Added commit hash to ignore this formatting change in git blame |
| publisher/Directory.Build.props | Reformatted XML with unconventional closing tag placement |
| publisher/Directory.Packages.props | Removed trailing empty line |
| publisher/NuGet.config | Added spaces to self-closing XML tags |
| publisher/src/LeanCode.Pipe/*.cs | Reformatted C# code with more compact chaining and lambda formatting |
| publisher/src/LeanCode.Pipe/*.csproj | Removed trailing empty lines and formatted XML tags |
| publisher/test/**/*.cs | Reformatted test files with more compact FluentAssertions chains |
| publisher/test/**/*.csproj | Removed trailing empty lines and formatted package references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: dotnet restore | ||
| - name: Check formatting | ||
| run: dotnet csharpier . --check | ||
| run: dotnet tool run csharpier check . |
There was a problem hiding this comment.
There's a double space in the command dotnet tool run csharpier (between "run" and "csharpier"). This should be a single space: dotnet tool run csharpier check .
| run: dotnet tool run csharpier check . | |
| run: dotnet tool run csharpier check . |
| <InformationalVersion Condition="'$(RepositoryCommit)' != ''" | ||
| >$(Version)+$(RepositoryCommit)</InformationalVersion | ||
| > | ||
| <InformationalVersion Condition="'$(RepositoryCommit)' == ''" | ||
| >$(Version)+local</InformationalVersion | ||
| > |
There was a problem hiding this comment.
[nitpick] The XML formatting here is unusual, with the closing > placed on separate lines (23-24 and 26-27). This is valid XML but unconventional. If this is the result of CSharpier's XML formatting, you may want to verify this is the intended behavior or consider adjusting CSharpier's configuration if it supports XML formatting rules.
| <InformationalVersion Condition="'$(RepositoryCommit)' != ''" | |
| >$(Version)+$(RepositoryCommit)</InformationalVersion | |
| > | |
| <InformationalVersion Condition="'$(RepositoryCommit)' == ''" | |
| >$(Version)+local</InformationalVersion | |
| > | |
| <InformationalVersion Condition="'$(RepositoryCommit)' != ''">$(Version)+$(RepositoryCommit)</InformationalVersion> | |
| <InformationalVersion Condition="'$(RepositoryCommit)' == ''">$(Version)+local</InformationalVersion> |
No description provided.