Conversation
Publisher Unit Test Results 5 files +1 5 suites +1 22s ⏱️ ±0s Results for commit a4f3e18. ± Comparison against base commit 0db5643. This pull request removes 12 and adds 12 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
This PR restructures the LeanCode.Pipe package by extracting Funnel-related functionality into separate packages: LeanCode.Pipe.Funnel.Core, LeanCode.Pipe.Funnel.Instance, and LeanCode.Pipe.Funnel.Publishing. The main package now contains only the core LeanPipe functionality without Funnel dependencies.
Key Changes:
- Split Funnel functionality into three dedicated packages
- Updated namespace from
LeanCode.Pipe.Funnel.FunnelledServicetoLeanCode.Pipe.Funnel.Publishing - Reorganized test structure with dedicated Funnel.Tests directory
- Updated CI/CD workflows to build and publish new packages
Reviewed changes
Copilot reviewed 50 out of 67 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
publisher/test/LeanCode.Pipe.Tests/LeanPipeServiceCollectionExtensionsTests.cs |
Removed Funnel-specific tests (moved to separate test project) |
publisher/test/LeanCode.Pipe.Tests/LeanCode.Pipe.Tests.csproj |
Added references to new Funnel packages for testing |
publisher/test/LeanCode.Pipe.Tests/ClaimsPrincipalJsonConverterTests.cs |
Updated namespace from LeanCode.Pipe.Tests.Funnel to LeanCode.Pipe.Tests |
publisher/test/LeanCode.Pipe.IntegrationTests/TestApplicationFactory.cs |
Updated to use fully qualified App.Program references |
publisher/test/LeanCode.Pipe.IntegrationTests/App/Program.cs |
Added explicit namespace and updated Funnel imports |
publisher/test/LeanCode.Pipe.ClientIntegrationTestsApp/Program.cs |
Updated namespace from FunnelledService to Publishing |
publisher/test/Funnel.Tests/** |
New scaling tests and test apps for Funnel functionality |
publisher/src/LeanCode.Pipe/** |
Moved internal classes (TopicExtractor, SubscriptionExecutor, etc.) and keys to main package |
publisher/src/Funnel/** |
New package structure (Core, Instance, Publishing) |
.github/workflows/** |
Updated workflows to test and publish new Funnel packages |
publisher/LeanCode.Pipe.sln |
Reorganized solution structure with nested folders |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mishioo
left a comment
There was a problem hiding this comment.
It would be good to update the docs on using the funnel. Other than that ![]()
Yeah, got it quite near in my backlog |
The main package LeanCode.Pipe, which included Funnel relevant stuff is being split into:
There shouldn't be any breaking change for anyone using LeanPipe.Pipe without the Funnel, but there are namespace changes in the Funnel Publishing package. Since basically no one relevant uses Funnel, I don't consider this a breaking change.
This PR doesn't change any functionality, even though the diff isn't that small.