Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
===========================================
- Coverage 86.98% 65.67% -21.32%
===========================================
Files 30 37 +7
Lines 684 906 +222
Branches 55 50 -5
===========================================
Hits 595 595
- Misses 67 290 +223
+ Partials 22 21 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive documentation for the LeanPipe Funnel feature, which enables distributed SignalR architectures. The documentation explains how Funnel solves horizontal scaling and microservices challenges by decoupling SignalR connection handling from notification publishing.
- New detailed README added at
publisher/src/Funnel/README.mdexplaining architecture, deployment scenarios, and setup - Project files updated to reference the new Funnel-specific README instead of the generic publisher README
- Existing READMEs updated with improved badge formatting and references to Funnel documentation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
publisher/src/Funnel/README.md |
New comprehensive documentation covering Funnel architecture, benefits, deployment scenarios, setup guides, and implementation details |
publisher/src/Funnel/Publishing/LeanCode.Pipe.Funnel.Publishing.csproj |
Updated README path from ../../../README.md to ../README.md to reference Funnel-specific documentation |
publisher/src/Funnel/Instance/LeanCode.Pipe.Funnel.Instance.csproj |
Updated README path from ../../../README.md to ../README.md to reference Funnel-specific documentation |
publisher/src/Funnel/Core/LeanCode.Pipe.Funnel.Core.csproj |
Updated README path from ../../../README.md to ../README.md to reference Funnel-specific documentation |
publisher/README.md |
Enhanced with clickable badges, added note about Funnel for distributed architectures, and updated SignalR documentation link |
README.md |
Added comprehensive badge collection for build status, package versions, and code coverage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.