Fix WM_NCCALCSIZE,WM_NCHITTEST: All Border Resize #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So I did some testing and found that these codes: - Enables resizing from all border sides. - Makes it so that the window doesn't resize that much (reduces only one pixel on the left, right, and bottom border) when changing titleBarStyle to "hidden". - Removing the WM_NCHITTEST makes the edges (top left, bottom right, etc) resize region bigger than it should be. - fOnResizeBorder should've been set to true (it was set to false) to enable resizing from top border. Issues: - The top side originally goes inside the title bar so someone has to figure out how to do that in titleBarStyle = "hidden". The top border IS resizable in titleBarStyle = "hidden" but only for exactly 1 pixel and that is very annoying. - SetResizable makes weird behavior (as usual) during titleBarStyle = "hidden"
Member
|
Thanks for your PR. |
Member
|
Will continue to follow up on these issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I did some testing and found that these codes:
Issues:
The top border IS resizable in titleBarStyle = "hidden" but only for exactly 1 pixel and that is very annoying.