Revert 8e10a60a8e5de52a6b8a1d4bca6bc0c0b6a1982f and fix the original issue #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The real issue was that a collapsed struct used as a secondary base would leave a gap in the downcast array, shifting all following bases' indices by 1. Instead of preventing a collapse of such structs, we instead fill the array slot with null. This is ok because the slot is not accessed (if it was, the struct would not have collapsed). We just need to keep the indexing consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real issue was that a collapsed struct used as a secondary base would leave a gap in the downcast array, shifting all following bases' indices by 1.
Instead of preventing a collapse of such structs, we instead fill the array slot with null.
This is ok because the slot is not accessed (if it was, the struct would not have collapsed). We just need to keep the indexing consistent.