Merged
Conversation
Contributor
Author
|
@GabrielaReyna Could you check for me if this is what you had in mind? If you have any ideas what we can do to improve the event callback section, please let me know. |
GabrielaReyna
requested changes
Jan 28, 2025
sites/cheerpx/src/content/docs/12-reference/CheerpX.Linux/04-setCustomConsole.md
Show resolved
Hide resolved
sites/cheerpx/src/content/docs/12-reference/CheerpX.Linux/05-setKmsCanvas.md
Show resolved
Hide resolved
Contributor
|
Excellent work! This is looking very good. Just added some comments to make it better and clearer but this is how I was picturing it :) |
GabrielaReyna
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.