Merged
Conversation
Deploying labs-browserpod-previews with
|
| Latest commit: |
d78799f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a1e7a7ed.labs-browserpod-previews.pages.dev |
| Branch Preview URL: | https://docs-restyling.labs-browserpod-previews.pages.dev |
codingfrog27
approved these changes
Feb 12, 2026
Contributor
codingfrog27
left a comment
There was a problem hiding this comment.
Looking good! I think this is a substantial improvement for user reading experience, great job 🔥
Testing
- I've browsed all preview sites, comparing them with with their live counterpart.
- Search bar is functional on all sites
- random links clicked and work as expected
Colours look good! I like the added "on this page" text as well.
And argument could be made that CheerpX's highlight colour should be more grey/dim. But I think it's good this way for the sake of contrast.
general notes/issues
I did notice a few things. They are not caused by this PR but seem worth noting in general. I've also added them as subtasks to my "further labs improvement" Asana task
- the TOC only start counting from the first heading and dont include the title. This makes the first paragraph non present or clickable
- When an item is clicked in the TOC it will scroll to the first line below the heading, I think it being on the heading would be slightly better
- in CheerpJ. Selecting Japanese from the drop down menu will link to a non existent page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
To test: