Feature/cid 2732/authenticate to ghe#2
Merged
mohamedlajmileanix merged 6 commits intomainfrom Jul 5, 2024
Merged
Conversation
mohamedlajmileanix
requested review from
AlperCezibarakLeanix,
ahmed-ali-55,
geoandri and
henriqamaral
LeanIX GitHub Agent Code Coverage
|
geoandri
reviewed
Jun 28, 2024
Contributor
geoandri
left a comment
geoandri
left a comment
There was a problem hiding this comment.
Since this is a public facing project, maybe is a good idea to follow the GitHub naming pattern in the class and variable names (e.g. gitHub instead of github)
mohamedlajmileanix
force-pushed
the
feature/CID-2732/authenticate-to-ghe
branch
from
53894be to
e116e60
Compare
henriqamaral
reviewed
Jul 4, 2024
src/main/kotlin/net/leanix/githubagent/GithubAgentApplication.kt
Outdated
Show resolved
Hide resolved
henriqamaral
reviewed
Jul 4, 2024
src/main/kotlin/net/leanix/githubagent/services/CachingService.kt
Outdated
Show resolved
Hide resolved
geoandri
reviewed
Jul 4, 2024
src/main/kotlin/net/leanix/githubagent/services/GitHubEnterpriseService.kt
Outdated
Show resolved
Hide resolved
geoandri
approved these changes
Jul 4, 2024
geoandri
reviewed
Jul 5, 2024
henriqamaral
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.