-
Notifications
You must be signed in to change notification settings - Fork 69
add Chinese translation #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the translations! On second thought, I think there are some instructional strings that should not be translated, e.g. the main infos on the landing page, the words "Preferences" and "Impressum", ... Or at least I shoudl check with uni if these things should stay in english Therefore I merged this manually! If you rebase this PR to |
|
(about the misstype, appartenly |
|
@joneugster, currently identified 4 points: |
I think I added all changes from this PR manually. The only things that should be left, are the translations of
As I'm not fully sure of the implications of having the server located in Germany and having these text in a language different than German or English. But I'd leave your PR here, so these translations could be added later. |
|
I think if you rebase @JiechengZhao , you should see that only few diffs remain |
Hi, I have rebased the code, and it looks good. Currently, I cannot generate new Game.pot or Game.json files with new keys based on the new lean4game branch. Which command will do the job? I thought you have mentioned but I cannot find it. |
|
in the lean4game repo, I think by the end of the week I will have integrated all these pieces, added the docs and updated NNG4 to use the new version completely. then I'll creat the |
|
@joneugster Please check and merge this P.R. There are still some scripts in server to update. |
|
ok, talked to my group. If we add the word "Impressum" in English, we can merge all of these changes, too! |
Cool. I also finished my test, so I think it is ready to merge. |


Add Translation of Chinese.
BTW, There are two
I think the second
we-llis a mistype. And now there is no i18next content use the key, so I deleted that.