This repository was archived by the owner on Jul 24, 2024. It is now read-only.
fix(category_theory/types): rename lemma ulift_functor.map#1133
Merged
mergify[bot] merged 3 commits intoJun 18, 2019
Conversation
…lemma Now we can use `ulift_functor.map` in the sense `functor.map ulift_functor`.
kim-em
previously requested changes
Jun 15, 2019
kim-em
left a comment
kim-em
left a comment
Collaborator
There was a problem hiding this comment.
Good idea to fix this.
I think the canonical name would be ulift_functor_map.
as suggested by @semorrison in leanprover-community#1133 (review)
rwbarton
approved these changes
Jun 15, 2019
rwbarton
added
the
ready-to-merge
Member
Author
|
@semorrison Fixed. Could you please resolve the "changes requested" status of your review? |
ChrisHughes24
approved these changes
Jun 17, 2019
ChrisHughes24
added
ready-to-merge
butterthebuddha
pushed a commit
to butterthebuddha/mathlib
that referenced
this pull request
May 15, 2020
…ver-community#1133) * fix(category_theory/types): avoid shadowing `ulift_functor.map` by a lemma Now we can use `ulift_functor.map` in the sense `functor.map ulift_functor`. * `ulift_functor.map_spec` → `ulift_functor_map` as suggested by @semorrison in leanprover-community#1133 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, one can use
ulift_functor.mapin the sensefunctor.map ulift_functor.TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list