This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(order/modular_lattice): Semimodular lattices#11602
Closed
YaelDillies wants to merge 6 commits into
Closed
[Merged by Bors] - feat(order/modular_lattice): Semimodular lattices#11602YaelDillies wants to merge 6 commits into
YaelDillies wants to merge 6 commits into
Conversation
YaelDillies
added
the
awaiting-review
jcommelin
added
awaiting-author
Collaborator
|
Can you add a reference? |
YaelDillies
added
awaiting-review
ocfnash
reviewed
Feb 21, 2022
Collaborator
I see you did add a reference but only to Wikipedia. If that's all there is then fine, but it would be great if there was an academic reference. |
Collaborator
|
Also, naming aside, this LGTM. |
ocfnash
added
awaiting-author
YaelDillies
added
awaiting-review
Collaborator
Author
|
I do not have a better reference unfortunately. But maybe @apnelson1 does? |
Collaborator
|
I would go with this one: Stern, M. (1999). Semimodular Lattices: Theory and Applications (Encyclopedia of Mathematics and its Applications). Cambridge: Cambridge University Press. doi:10.1017/CBO9780511665578 |
leanprover-community-bot-assistant
added
ready-to-merge
bors Bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
This defines the four main kinds of semimodular lattices: * Weakly upper modular * Weakly lower modular * Upper modular * Lower modular
|
Build failed (retrying...): |
Member
|
I'll add it back to queue in a minute. |
|
Canceled. |
Member
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
This defines the four main kinds of semimodular lattices: * Weakly upper modular * Weakly lower modular * Upper modular * Lower modular
|
Pull request successfully merged into master. Build succeeded: |
bors
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This defines the four main kinds of semimodular lattices: