This repository was archived by the owner on Jul 24, 2024. It is now read-only.
chore(algebra/group/to_additive): map_namespace should make a meta constant#1409
Merged
mergify[bot] merged 5 commits intomasterfrom Sep 10, 2019
Merged
chore(algebra/group/to_additive): map_namespace should make a meta constant#1409mergify[bot] merged 5 commits intomasterfrom
mergify[bot] merged 5 commits intomasterfrom
Conversation
…nstance `map_namespace` now produces a `meta constant` instead of a constant. This means that after importing `group_theory/coset` and typing `#print axioms`, `quotient_group._to_additive` is not in the list, since it is now a `meta constant`. This is a little bit neater, and it doesn't look like we're adding any axioms.
Member
|
Oh, it seems that |
Collaborator
|
Is this constant a place to keep an attribute cache? Can we use a definition of the shape |
Collaborator
|
I agree with Simon; constants seem completely unnecessary |
Member
Author
This is now done. |
robertylewis
approved these changes
Sep 10, 2019
robertylewis
added
the
ready-to-merge
butterthebuddha
pushed a commit
to butterthebuddha/mathlib
that referenced
this pull request
May 15, 2020
…nstant (leanprover-community#1409) * chore(algebra/group/to_additive): map_namespace should make a meta constance `map_namespace` now produces a `meta constant` instead of a constant. This means that after importing `group_theory/coset` and typing `#print axioms`, `quotient_group._to_additive` is not in the list, since it is now a `meta constant`. This is a little bit neater, and it doesn't look like we're adding any axioms. * Update to_additive.lean * Update to_additive.lean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map_namespacenow produces ameta constantinstead of a constant. This means that after importinggroup_theory/cosetand typing#print axioms,quotient_group._to_additiveis not in the list, since it is now ameta constant. This is a little bit neater, and it doesn't look like we're adding any axioms.TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list