Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(data/list/alist): recursion on alist using insert#15434

Closed
vihdzp wants to merge 9 commits intomasterfrom
alist_recursion
Closed

[Merged by Bors] - feat(data/list/alist): recursion on alist using insert#15434
vihdzp wants to merge 9 commits intomasterfrom
alist_recursion

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Jul 16, 2022

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Jul 16, 2022
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 18, 2022
@vihdzp vihdzp added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 19, 2022
Copy link
Copy Markdown
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of interest what do you want to use this for?

@b-mehta b-mehta added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 10, 2022
@vihdzp
Copy link
Copy Markdown
Collaborator Author

vihdzp commented Aug 10, 2022

Doing some proofs on association lists, I found this to be useful at times where I didn't want to interface directly with the underlying list.

@vihdzp vihdzp added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 11, 2022
Copy link
Copy Markdown
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link
Copy Markdown

bors bot commented Oct 5, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@vihdzp
Copy link
Copy Markdown
Collaborator Author

vihdzp commented Jan 19, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jan 20, 2023
@vihdzp
Copy link
Copy Markdown
Collaborator Author

vihdzp commented Jan 20, 2023

I see that this modifies a synchronized file. I'll PR these changes to Mathlib 4 very shortly (as soon as I get push access!).

@vihdzp vihdzp added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Jan 20, 2023
@bors
Copy link
Copy Markdown

bors bot commented Jan 20, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/list/alist): recursion on alist using insert [Merged by Bors] - feat(data/list/alist): recursion on alist using insert Jan 20, 2023
@bors bors bot closed this Jan 20, 2023
@bors bors bot deleted the alist_recursion branch January 20, 2023 02:55
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Feb 27, 2023
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 21, 2023
Mathlib4 pair for leanprover-community/mathlib3#15434



Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants