Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(category_theory/functor_category): monos in the functor category - #4811

Closed
b-mehta wants to merge 1 commit into
masterfrom
nat-trans-mono
Closed

[Merged by Bors] - feat(category_theory/functor_category): monos in the functor category#4811
b-mehta wants to merge 1 commit into
masterfrom
nat-trans-mono

Conversation

@b-mehta

@b-mehta b-mehta commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

@b-mehta b-mehta added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Oct 28, 2020
congr_fun (congr_arg app (T.naturality f)) Z

/-- A natural transformation is a monomorphism if each component is. -/
lemma mono_app_of_mono (α : F ⟶ G) [∀ (X : C), mono (α.app X)] : mono α :=

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want the [..]? I guess that typeclass inference will not be able to find those instances. Probably there would first need to be a dsimp that unfolds the app into something for which an instance exists.
And with the [..], applying the lemma will fail if it can find the instance. So it might be better to use (..) and then call apply_instance in those cases where find the instance is actually possible.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fair point - I was mimicking what's done in natural_isomorphism.lean, where it has

def is_iso_of_is_iso_app (α : F ⟶ G) [∀ X : C, is_iso (α.app X)] : is_iso α :=

so I thought this version should be okay - I don't mind changing though

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh well, if it's also done over there, let's try this. If it doesn't work, it's easy enough to change.

@jcommelin

Copy link
Copy Markdown
Member

Thanks 🎉

bors merge

@github-actions github-actions Bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 29, 2020
@bors

bors Bot commented Oct 29, 2020

Copy link
Copy Markdown

Pull request successfully merged into master.

Build succeeded:

@bors bors Bot changed the title feat(category_theory/functor_category): monos in the functor category [Merged by Bors] - feat(category_theory/functor_category): monos in the functor category Oct 29, 2020
@bors bors Bot closed this Oct 29, 2020
@bors
bors Bot deleted the nat-trans-mono branch October 29, 2020 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants