Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

refactor(order/conditionally_complete_lattice): refactor definition, add constructors#8496

Open
urkud wants to merge 60 commits into
masterfrom
ccl-Sup
Open

refactor(order/conditionally_complete_lattice): refactor definition, add constructors#8496
urkud wants to merge 60 commits into
masterfrom
ccl-Sup

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Aug 1, 2021

Conditionally complete lattices

  • reformulate the definition of conditionally_complete_lattice in terms of is_lub/is_glb; this way all instances in mathlib become shorter;
  • add a new constructor conditionally_complete_lattice_of_is_lub_of_rel_iso and use it for reals and integers;
  • add lemmas is_lub_csupr, is_lub_csupr_set, is_lub.csupr_eq, is_lub.csupr_set_eq, and their analogues for infi;
  • add is_greatest.Sup_mem and is_least.Inf_mem;
  • golf some proofs about nat, use named properties like bdd_above and set.nonempty;
  • add nat.is_least_Inf, nat.is_lub_Sup, and nat.is_greatest_Sup.

Real numbers

  • drop lemmas like real.Sup_le when they are not better than lemmas from order.conditionally_complete_order;
  • drop bdd_above/bdd_below assumptions in real.add_neg_lt_Sup and real.lt_Inf_add_pos;

Other changes

  • add set.inv_empty, set.inv_univ, set.neg_empty, set.neg_univ;
  • add function.surjective.nonempty_preimage and function.monotone_eval;
  • add is_lub_pi and is_glb_pi

Open in Gitpod

urkud added 11 commits August 1, 2021 01:13
* `Sup_eq_supr'` only needs `[has_Sup α]`, add `Inf_eq_infi'`;
* add `supr_range'`, `infi_range'`, `Sup_image'`, `Inf_image'`
  lemmas that use supremum/infimum over subtypes and only require
  `[has_Sup]`/`[has_Inf]`.
Move `least_of_bdd`, `exists_least_of_bdd`, `coe_least_of_bdd_eq`,
`greatest_of_bdd`, `exists_greatest_of_bdd`, and
`coe_greatest_of_bdd_eq` from `data.int.basic` to `data.int.order`.
@urkud urkud added the WIP Work in progress label Aug 1, 2021
@github-actions github-actions Bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 1, 2021
@github-actions github-actions Bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 2, 2021
@github-actions github-actions Bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 2, 2021
@github-actions github-actions Bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Aug 2, 2021
* add `covariant.flip` and `contravariant.flip`;
* add `[to_additive]` to `group.covariant_iff_contravariant` and
  `covconv` (renamed to `group.covconv`);
* use `group.covconv` in
  `group.covariant_class_le.to_contravariant_class_le`;
* add some `order_dual` instances for `covariant_class` and
  `contravariant_class`;
* golf `order_dual.ordered_comm_monoid`.
@github-actions github-actions Bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 4, 2021
@github-actions github-actions Bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 4, 2021
@github-actions github-actions Bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 4, 2021
@github-actions github-actions Bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 6, 2021
@github-actions github-actions Bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Aug 15, 2021
@kim-em kim-em added the too-late This PR was ready too late for inclusion in mathlib3 label Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

merge-conflict Please `git merge origin/master` then a bot will remove this label. too-late This PR was ready too late for inclusion in mathlib3 WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants