This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(data/real/basic): cleanup#8501
Closed
urkud wants to merge 2 commits into
Closed
Conversation
eric-wieser
reviewed
Aug 1, 2021
| end | ||
|
|
||
| noncomputable instance : has_Sup ℝ := | ||
| ⟨λ S, if h : (∃ x, x ∈ S) ∧ (∃ x, ∀ y ∈ S, y ≤ x) |
Member
There was a problem hiding this comment.
Is it worth replacing this (and below) with the named props too?
Suggested change
| ⟨λ S, if h : (∃ x, x ∈ S) ∧ (∃ x, ∀ y ∈ S, y ≤ x) | |
| ⟨λ S, if h : S.nonempty ∧ bdd_above S |
Member
Author
There was a problem hiding this comment.
I'm going to generalize this constructor, so these lines will go away soon.
4 tasks
Member
|
bors merge |
github-actions
Bot
added
ready-to-merge
bors Bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
* use `is_lub` etc in the statement of `real.exists_sup`, rename it to `real.exists_is_lub`; * move parts of the proof of `real.exists_is_lub` around;
|
Pull request successfully merged into master. Build succeeded: |
bors
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_lubetc in the statement ofreal.exists_sup, rename it toreal.exists_is_lub;real.exists_is_lubaround;