Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

feat(set_theory/zfc/ordinal): definition of von Neumann ordinals#18513

Open
vihdzp wants to merge 4 commits intomasterfrom
zfc_ordinal_p0.5
Open

feat(set_theory/zfc/ordinal): definition of von Neumann ordinals#18513
vihdzp wants to merge 4 commits intomasterfrom
zfc_ordinal_p0.5

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Feb 28, 2023

We define von Neumann ordinals and prove some very basic theorems.

For the reasoning behind my choice of definition, see https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/hereditarily/near/338586303.


Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Feb 28, 2023
@kim-em
Copy link
Copy Markdown
Collaborator

kim-em commented Mar 28, 2023

Could the @vihdzp and @negiizhao work out which of these two PRs should remain open, and close the other one?

@kim-em kim-em added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 28, 2023
@vihdzp
Copy link
Copy Markdown
Collaborator Author

vihdzp commented Mar 29, 2023

The other PR was closed.

@vihdzp vihdzp added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 30, 2023
@eric-wieser eric-wieser added the not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 label Jul 15, 2023
- A transitive set that's (strictly) totally ordered under `∈`.
- A transitive set that's well-ordered under `∈`.
-/
def is_ordinal (x : Set) : Prop := x.is_transitive ∧ ∀ y z w : Set, y ∈ z → z ∈ w → w ∈ x → y ∈ w
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def is_ordinal (x : Set) : Prop := x.is_transitive ∧ ∀ y z w : Set, y ∈ z → z ∈ w → w ∈ x → y ∈ w
def is_ordinal (x : Set) : Prop := x.is_transitive ∧ ∀ w ∈ x, w.is_transitive

the definition here is just writing out what is_transitive means, which seems unnecessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

awaiting-review The author would like community review of the PR not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants