This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(linear_algebra/dfinsupp): make lsum a linear_equiv#6185
Closed
eric-wieser wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - chore(linear_algebra/dfinsupp): make lsum a linear_equiv#6185eric-wieser wants to merge 5 commits intomasterfrom
eric-wieser wants to merge 5 commits intomasterfrom
Conversation
eric-wieser
added
the
awaiting-review
kim-em
reviewed
Feb 12, 2021
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
eric-wieser
commented
Feb 12, 2021
kim-em
reviewed
Feb 14, 2021
Comment on lines
+94
to
+99
| instance semimodule_of_linear_map [semiring S] [semimodule S N] [smul_comm_class R S N] : | ||
| by haveI : add_comm_monoid (Π₀ i, M i →ₗ[R] N) := | ||
| @dfinsupp.add_comm_monoid _ (λ i, M i →ₗ[R] N) _; | ||
| exactI semimodule S (Π₀ (i : ι), M i →ₗ[R] N) := | ||
| let unused := S in | ||
| @dfinsupp.semimodule _ (λ i, M i →ₗ[R] N) _ _ _ _ |
Collaborator
There was a problem hiding this comment.
Suggested change
| instance semimodule_of_linear_map [semiring S] [semimodule S N] [smul_comm_class R S N] : | |
| by haveI : add_comm_monoid (Π₀ i, M i →ₗ[R] N) := | |
| @dfinsupp.add_comm_monoid _ (λ i, M i →ₗ[R] N) _; | |
| exactI semimodule S (Π₀ (i : ι), M i →ₗ[R] N) := | |
| let unused := S in | |
| @dfinsupp.semimodule _ (λ i, M i →ₗ[R] N) _ _ _ _ | |
| instance semimodule_of_linear_map [semiring S] [semimodule S N] [smul_comm_class R S N] : | |
| @semimodule S (Π₀ (i : ι), M i →ₗ[R] N) _ (@dfinsupp.add_comm_monoid _ (λ i, M i →ₗ[R] N) _) := | |
| @dfinsupp.semimodule _ (λ i, M i →ₗ[R] N) _ _ _ _ |
Collaborator
|
Besides the suggestion and perhaps toning down the comment (it's not quite as excruciating now, hopefully!), looks good to me. bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
kim-em
added
delegated
Member
Author
|
Found a slightly tidier solution by adding a second manual instance. This refers to a library note added in #6183, so shouldn't be put on the queue until that library note name is confirmed. |
github-actions
Bot
added
the
blocked-by-other-PR
Member
Author
|
bors r+ |
|
👎 Rejected by label |
eric-wieser
added
ready-to-merge
Member
Author
|
bors r+ |
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
bors Bot
pushed a commit
that referenced
this pull request
Feb 16, 2021
[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Typeclass.20inference.20can't.20fill.20in.20parameters/near/226019081) with a summary of the problem which required the nasty `semimodule_of_linear_map` present here.
|
Pull request successfully merged into master. Build succeeded: |
bors
Bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Typeclass.20inference.20can't.20fill.20in.20parameters/near/226019081) with a summary of the problem which required the nasty `semimodule_of_linear_map` present here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zulip thread with a summary of the problem which required the nasty
semimodule_of_linear_mappresent here.