Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

cleanup(*): removing uses of bare have#676

Merged
johoelzl merged 2 commits into
masterfrom
bare-have
Feb 3, 2019
Merged

cleanup(*): removing uses of bare have#676
johoelzl merged 2 commits into
masterfrom
bare-have

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented Feb 2, 2019

Using a bare have, which creates a new goal of type ?m_1, seems unnecessarily obfuscatory. There are only two instances in mathlib, so I've added the explicit type to the have statement.

@kim-em kim-em requested a review from johoelzl February 2, 2019 02:35
@digama0
Copy link
Copy Markdown
Member

digama0 commented Feb 2, 2019

I'm okay with these changes, but for context the idea here is to have a refine like version of have := bla, where bla has holes that are filled later. The problem with using have := bla _ bla, literally is that the holes appear after the main goal, which can be problematic if you want to dispense with them first. So it turns into have, refine bla _ bla, which is what you see here.

@kim-em
Copy link
Copy Markdown
Collaborator Author

kim-em commented Feb 2, 2019 via email

@kckennylau
Copy link
Copy Markdown
Collaborator

How do you know there are only two instances?

@kim-em
Copy link
Copy Markdown
Collaborator Author

kim-em commented Feb 3, 2019 via email

@johoelzl johoelzl merged commit f5bd340 into master Feb 3, 2019
@kim-em kim-em deleted the bare-have branch February 5, 2019 00:20
cipher1024 pushed a commit that referenced this pull request Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants