This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Conversation
Member
|
I'm okay with these changes, but for context the idea here is to have a |
Collaborator
Author
|
I see. In these cases the explicit type is not too verbose, but I certainly
appreciate that this won't always be the case.
…On Sat, Feb 2, 2019, 2:59 PM Mario Carneiro ***@***.*** wrote:
I'm okay with these changes, but for context the idea here is to have a
refine like version of have := bla, where bla has holes that are filled
later. The problem with using have := bla _ bla, literally is that the
holes appear after the main goal, which can be problematic if you want to
dispense with them first. So it turns into have, refine bla _ bla, which
is what you see here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#676 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAdLBG0Ggr0Cg46usJ8agaMHFg4ou5_sks5vJQ0vgaJpZM4afXxn>
.
|
Collaborator
|
How do you know there are only two instances? |
Collaborator
Author
|
I just searched for 'have,'.
…On Sun, Feb 3, 2019, 9:02 AM Kenny Lau ***@***.*** wrote:
How do you know there are only two instances?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#676 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAdLBPYQmQwhNxDEErGhFOvp0OygrJFRks5vJgr7gaJpZM4afXxn>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a bare
have, which creates a new goal of type?m_1, seems unnecessarily obfuscatory. There are only two instances in mathlib, so I've added the explicit type to thehavestatement.