refactor: fix import error with Mathlib#1059
Merged
jstoobysmith merged 4 commits intomasterfrom Apr 27, 2026
Merged
Conversation
zhikaip
reviewed
Apr 25, 2026
| -/ | ||
|
|
||
| @[expose] public section | ||
| open Physlib |
Collaborator
There was a problem hiding this comment.
Suggested change
| open Physlib | |
| open Physlib | |
The OCD in me wants the new line (or removing it) to be consistent. Is it possible to have linters that check this or is opening namespaces too ad-hoc?
zhikaip
reviewed
Apr 25, 2026
| @@ -40,6 +40,7 @@ properties about it. | |||
| -/ | |||
|
|
|||
| @[expose] public section | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| @[expose] public section | |
| @[expose] public section | |
also for this line, I'm being a bit pedantic here but would be nice if consistent. I think the default from modulising has an extra line gap. Just raising it, it's fine if you think it's better if we don't have this line, maybe we can do a pass on the whole of Physlib later
Member
Author
|
@zhikaip should have addressed these spacing issues here. I agree that there should be a linter for this and general linters around |
zhikaip
approved these changes
Apr 27, 2026
Collaborator
zhikaip
left a comment
zhikaip
left a comment
There was a problem hiding this comment.
Many thanks, let's go with this for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put distributions in the namespace
Physlibto prevent an error mentioned herehttps://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/Conflict.20when.20importing.20Mathlib.20and.20Physlib/with/590839433
when importing Physlib and Mathlib at the same time.
More long term solutions to prevent such things are mentioned there.