feat(AxiomatizedEntropy): expand RelEntropy API and add Hellinger overlap#1098
Open
dennj wants to merge 1 commit into
Open
feat(AxiomatizedEntropy): expand RelEntropy API and add Hellinger overlap#1098dennj wants to merge 1 commit into
dennj wants to merge 1 commit into
Conversation
dennj
changed the title
Member
There was a problem hiding this comment.
I think this file is getting pretty long now. Is it possible we can split it up into seperate modules (hopefully in line with some nice API structure)?
Collaborator
There was a problem hiding this comment.
Yeah, definitely a lot of this isn't "Defs". Most of it could go in another AxiomatizedEntropy file, the stuff that isn't filling in sorries already in there. At a minimum the Defs file shouldn't depend on the DPI file.
jstoobysmith
added
the
awaiting-author
Collaborator
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.