refactor: Reorganise the QuantumInfo directory #1124
Open
jstoobysmith wants to merge 5 commits into
Open
Conversation
wock9000
approved these changes
May 26, 2026
Contributor
wock9000
left a comment
There was a problem hiding this comment.
Tested locally — builds clean. Verified that BargmannInvariant.lean works correctly at the new States/Pure/ path with the updated import.
The States/Pure/ vs States/Mixed/ split is clean. For our follow-up PRs (Pancharatnam solid angle, N-level generalization), the placement under States/Pure/ makes sense since geometric phase is a property of pure state evolution.
One note for our own tracking: our open PR #1126 targets QuantumInfo/Finite/GeometricPhase/ which will need rebasing once this merges. Happy to handle that.
Collaborator
|
I think the organization makes sense, but I'd like to wait for approval from someone more familiar with QuantumInfo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No changes to content, just a reorganisation. New directory structure is the following: