refactor: extract Shrinkable to its own non-meta module#76
Merged
Conversation
`Shrinkable` and all its basic instances have no meta dependencies — they're pure functions on `List`, `Nat`, etc. Having them inside the `public meta section` in `Sampleable.lean` forces downstream users to define their `Shrinkable` instances as meta, which prevents them from using derived non-meta instances like `BEq` (due to LCNF visibility checking in Lean v4.30). Extract `Shrinkable` and the shrinker instances to `Plausible/Shrinkable.lean` (non-meta) and import it from `Sampleable.lean` (both non-meta and meta, so meta code can still use it). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shrinkableand all its basic instances have no meta dependencies — they're pure functions onList,Nat, etc. Having them inside thepublic meta sectioninSampleable.leanforces downstream users to define theirShrinkableinstances as meta, which prevents them from using derived non-meta typeclass instances likeBEq(due to LCNF visibility checking in Lean v4.30).This PR extracts
Shrinkableand the shrinker instances toPlausible/Shrinkable.lean(non-meta) and imports it fromSampleable.lean(both non-meta and meta, so meta code can still use it).🤖 Prepared with Claude Code