Support defs in axiom checking and improve error messages #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGross
commented
Dec 20, 2025
JasonGross
commented
- Add constantKindName helper to get human-readable names for constant kinds
- Allow checkAxioms to accept both theorems and defs as targets
- Include constant kind in error message when target is unsupported
- Add constantKindName helper to get human-readable names for constant kinds - Allow checkAxioms to accept both theorems and defs as targets - Include constant kind in error message when target is unsupported
JasonGross
commented
Dec 20, 2025
JasonGross
commented
Dec 20, 2025
JasonGross
added a commit
to JasonGross/comparator
that referenced
this pull request
Dec 20, 2025
This PR allows challenges that demand the construction of terms of non-Prop types. We remove the error "Challenge and solution constant kind don't match" in favor of permitting any kind of solution to a challenge that is a theorem or axiom. Note that permitted axioms must still be declared as axioms or theorems in the solution; it would invite inconsistency if we allowed instantiating informative axioms with definitions. The optional field "allow_partial" indicates whether or not challenges may be solved with `partial def` solutions. We uniformly forbid unsafe solutions. We rely on the Lean kernel to mark as unsafe (resp. partial) any definitions that make use of unsafe (resp. partial) dependencies. Fixes #3 (mostly) Fixes #4 Closes leanprover#5 Closes leanprover#6 Closes leanprover#7
JasonGross
added a commit
to JasonGross/comparator
that referenced
this pull request
Dec 20, 2025
This PR allows challenges that demand the construction of terms of non-Prop types. We remove the error "Challenge and solution constant kind don't match" in favor of permitting any kind of solution to a challenge that is a theorem or axiom. Note that permitted axioms must still be declared as axioms or theorems in the solution; it would invite inconsistency if we allowed instantiating informative axioms with definitions. The optional field "allow_partial" indicates whether or not challenges may be solved with `partial def` solutions. We uniformly forbid unsafe solutions. We rely on the Lean kernel to mark as unsafe (resp. partial) any definitions that make use of unsafe (resp. partial) dependencies. Fixes #3 (mostly) Fixes #4 Closes leanprover#5 Closes leanprover#6 Closes leanprover#7
JasonGross
added a commit
to JasonGross/comparator
that referenced
this pull request
Dec 20, 2025
This PR allows challenges that demand the construction of terms of non-Prop types. We remove the error "Challenge and solution constant kind don't match" in favor of permitting any kind of solution to a challenge that is a theorem or axiom. Note that permitted axioms must still be declared as axioms or theorems in the solution; it would invite inconsistency if we allowed instantiating informative axioms with definitions. The optional field "allow_partial" indicates whether or not challenges may be solved with `partial def` solutions. We uniformly forbid unsafe solutions. We rely on the Lean kernel to mark as unsafe (resp. partial) any definitions that make use of unsafe (resp. partial) dependencies. Fixes #3 (mostly) Fixes #4 Closes leanprover#5 Closes leanprover#6 Closes leanprover#7
JasonGross
added a commit
to JasonGross/comparator
that referenced
this pull request
Dec 20, 2025
This PR allows challenges that demand the construction of terms of non-Prop types. We remove the error "Challenge and solution constant kind don't match" in favor of permitting any kind of solution to a challenge that is a theorem or axiom. Note that permitted axioms must still be declared as axioms or theorems in the solution; it would invite inconsistency if we allowed instantiating informative axioms with definitions. The optional field "allow_partial" indicates whether or not challenges may be solved with `partial def` solutions. We uniformly forbid unsafe solutions. We rely on the Lean kernel to mark as unsafe (resp. partial) any definitions that make use of unsafe (resp. partial) dependencies. Fixes #3 (mostly) Fixes #4 Closes leanprover#5 Closes leanprover#6 Closes leanprover#7
JasonGross
added a commit
to JasonGross/comparator
that referenced
this pull request
Dec 20, 2025
This PR allows challenges that demand the construction of terms of non-Prop types. We remove the error "Challenge and solution constant kind don't match" in favor of permitting any kind of solution to a challenge that is a theorem or axiom. Note that permitted axioms must still be declared as axioms or theorems in the solution; it would invite inconsistency if we allowed instantiating informative axioms with definitions. The optional field "allow_partial" indicates whether or not challenges may be solved with `partial def` solutions. We uniformly forbid unsafe solutions. We rely on the Lean kernel to mark as unsafe (resp. partial) any definitions that make use of unsafe (resp. partial) dependencies. Fixes #3 (mostly) Fixes #4 Closes leanprover#5 Closes leanprover#6 Closes leanprover#7
JasonGross
added a commit
to JasonGross/comparator
that referenced
this pull request
Dec 20, 2025
This PR allows challenges that demand the construction of terms of non-Prop types. We remove the error "Challenge and solution constant kind don't match" in favor of permitting any kind of solution to a challenge that is a theorem or axiom. Note that permitted axioms must still be declared as axioms or theorems in the solution; it would invite inconsistency if we allowed instantiating informative axioms with definitions. The optional field "allow_partial" indicates whether or not challenges may be solved with `partial def` solutions. We uniformly forbid unsafe solutions. We rely on the Lean kernel to mark as unsafe (resp. partial) any definitions that make use of unsafe (resp. partial) dependencies. Fixes #3 (mostly) Fixes #4 Closes leanprover#5 Closes leanprover#6 Closes leanprover#7
JasonGross
added a commit
to JasonGross/comparator
that referenced
this pull request
Dec 20, 2025
This PR allows challenges that demand the construction of terms of non-Prop types. We remove the error "Challenge and solution constant kind don't match" in favor of permitting any kind of solution to a challenge that is a theorem or axiom. Note that permitted axioms must still be declared as axioms or theorems in the solution; it would invite inconsistency if we allowed instantiating informative axioms with definitions. The optional field "allow_partial" indicates whether or not challenges may be solved with `partial def` solutions. We uniformly forbid unsafe solutions. We rely on the Lean kernel to mark as unsafe (resp. partial) any definitions that make use of unsafe (resp. partial) dependencies. Axioms is now responsible for ensuring that solutions to challenges are present and have valid kinds (no forbidden axioms recursively; only partial if permitted; not unsafe) Compare is is responsible for ensuring that: - targets are present and are axioms or theorems in the challenge file - targets have the same type in the challenge and solution - any dependency of a solution, which is not an explicit target, and which occurs in both the challenge and the solution, has the same contents in both Fixes #3 (mostly) Fixes #4 Closes leanprover#5 Closes leanprover#6 Closes leanprover#7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.