feat: environment linters #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmontesi
approved these changes
Oct 24, 2025
fmontesi
pushed a commit
that referenced
this pull request
Oct 29, 2025
This PR adds almost all the lints that were left commented out in #123. All that remains is documentation linting and `explicitVarsOfIff` which I felt might be too opinionated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds environment linters to our testing, including one I have written to check that all new declarations fall under either an existing upstream or
Cslibnamespace. The remaining environment linters are fromBatteries. I have left a few commented out that currently fail and could be addressed in follow-up PRs. Note that we can ignore individual failures withnolint.Regarding performance, this seems practical when limited to the
Cslibnamespace. It is now taking ~25s for me to runlake testlocally on the freshly built repo.