Skip to content

chore: simplify the DFA example#430

Merged
chenson2018 merged 2 commits intomainfrom
eric-wieser-patch-1
Mar 17, 2026
Merged

chore: simplify the DFA example#430
chenson2018 merged 2 commits intomainfrom
eric-wieser-patch-1

Conversation

@eric-wieser
Copy link
Copy Markdown
Collaborator

@eric-wieser eric-wieser commented Mar 17, 2026

The deriving Fintype machinery in mathlib already does the hard work here, and the Finite theorems were useless.

@chenson2018 chenson2018 enabled auto-merge March 17, 2026 03:19
Copy link
Copy Markdown
Collaborator

@chenson2018 chenson2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenson2018 chenson2018 added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit ea86c67 Mar 17, 2026
3 checks passed
m-ow pushed a commit to m-ow/cslib that referenced this pull request Mar 17, 2026
The `deriving Fintype` machinery in mathlib already does the hard work
here, and the `Finite` theorems were useless.
thomaskwaring pushed a commit to thomaskwaring/cslib_SKI that referenced this pull request Apr 6, 2026
The `deriving Fintype` machinery in mathlib already does the hard work
here, and the `Finite` theorems were useless.
tannerduve pushed a commit to tannerduve/cslib that referenced this pull request Apr 22, 2026
The `deriving Fintype` machinery in mathlib already does the hard work
here, and the `Finite` theorems were useless.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants