Merged
Conversation
…e in Semantics/LTS/Basic that messed with my progress.
Closed
fmontesi
reviewed
Mar 19, 2026
| have hprefix := LTS.STrN.tr hprefix_τ htr hstr2 | ||
| have conc := LTS.STrN.append lts hprefix h3 | ||
| grind | ||
| [HasTau Label] (lts : LTS State Label) |
Collaborator
There was a problem hiding this comment.
Needs double indentation per Mathlib style. In general, all lines after the first and before the := are doubly-indented. Please apply also to your other modifications. :-)
Collaborator
|
LGTM assuming CI passes. There's just a minor style fix to apply (see my comment), and then I'm happy to merge this! Thanks for cleaning it up! :-) |
fmontesi
requested changes
Mar 20, 2026
Collaborator
|
Merging this so that it doesn't become stale, since we're planning a round of refactoring of LTS anyway. |
fmontesi
approved these changes
Mar 23, 2026
thomaskwaring
pushed a commit
to thomaskwaring/cslib_SKI
that referenced
this pull request
Apr 6, 2026
Introducing a saturated tau transition to make the definition of weak bisimulation closer to the definition of branching bisimulation (which is a todo still). Also, it removes the need for STrN, since inductive proofs on weak bisimulation can now simply follow the inductive definition. Two files are updated: Semantics/LTS/Basic and Semantics/LTS/Bisimulation I had a previous PR on this leanprover#220, which I "restarted" because the .git history got messed up a bit after there were quite a few changes to Semantics/LTS/Basic. In short, I am removing the definition of STrN which, imo, is not necessary anymore. But the recent changes placed it back, and I needed a restart to make sure I was not damaging anything.
tannerduve
pushed a commit
to tannerduve/cslib
that referenced
this pull request
Apr 22, 2026
Introducing a saturated tau transition to make the definition of weak bisimulation closer to the definition of branching bisimulation (which is a todo still). Also, it removes the need for STrN, since inductive proofs on weak bisimulation can now simply follow the inductive definition. Two files are updated: Semantics/LTS/Basic and Semantics/LTS/Bisimulation I had a previous PR on this leanprover#220, which I "restarted" because the .git history got messed up a bit after there were quite a few changes to Semantics/LTS/Basic. In short, I am removing the definition of STrN which, imo, is not necessary anymore. But the recent changes placed it back, and I needed a restart to make sure I was not damaging anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing a saturated tau transition to make the definition of weak bisimulation closer to the definition of branching bisimulation (which is a todo still). Also, it removes the need for STrN, since inductive proofs on weak bisimulation can now simply follow the inductive definition.
Two files are updated: Semantics/LTS/Basic and Semantics/LTS/Bisimulation
I had a previous PR on this #220, which I "restarted" because the .git history got messed up a bit after there were quite a few changes to Semantics/LTS/Basic. In short, I am removing the definition of STrN which, imo, is not necessary anymore. But the recent changes placed it back, and I needed a restart to make sure I was not damaging anything.