chore: conform to header linter#517
Merged
chenson2018 merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
chenson2018
commented
Apr 24, 2026
|
|
||
| public import Cslib.Init | ||
|
|
||
| /-! -/ |
|
|
||
| public import Cslib.Init | ||
|
|
||
| /-! -/ |
|
|
||
| public import Cslib.Logics.LinearLogic.CLL.Basic | ||
|
|
||
| /-! -/ |
|
|
||
| public import Cslib.Computability.Languages.OmegaLanguage | ||
|
|
||
| /-! -/ |
| public import Cslib.Init | ||
| public import Mathlib.Computability.Language | ||
|
|
||
| /-! -/ |
ctchou
added a commit
to akhilesh-balaji/cslib
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently discovered that while the header linter is included as part of the weekly linting set that CSLib enables, its implementation was such that it only worked in Mathlib. Kim has kindly fixed this in leanprover-community/mathlib4#38396, which should be merged soon.
Unfortunately, when I did the port to the module system, I accidentally placed some of the
public sectionincorrectly above the module docstring, getting no warning from the header linter, and subsequently others followed my lead. Most of the changes here are just this, plus just a few missing module docstrings and typos.