feat: precise close_var_not_fvar#585
Closed
lengyijun wants to merge 1 commit into
Closed
Conversation
This PR: 1. Rename `close_preserve_not_fvar` to `close_rec_fv` : shorter name, easier to remember 2. Remove `close_var_not_fvar_rec`: `close_rec_fv` is stronger theorem 3. Refactor `close_var_not_fvar`: make it precise 4. Add `close_rec_fv` and `close_var_not_fvar` to grind Following leanprover#580
Contributor
Author
|
We can even remove diff --git a/Cslib/Languages/LambdaCalculus/LocallyNameless/Untyped/Properties.lean b/Cslib/Languages/LambdaCalculus/LocallyNameless/Untyped/Properties.lean
index fa839e4f9f67..304e7fb6810f 100644
--- a/Cslib/Languages/LambdaCalculus/LocallyNameless/Untyped/Properties.lean
+++ b/Cslib/Languages/LambdaCalculus/LocallyNameless/Untyped/Properties.lean
@@ -136,7 +136,7 @@ lemma open_close_to_subst (m : Term Var) (x y : Var) (k : ℕ) (m_lc : LC m) :
grind [
swap_open, =_ swap_open_fvar_close,
open_close x' (t⟦k+1 ↜ x⟧⟦k+1 ↝ fvar y⟧) 0, open_close x' (t[x := fvar y]) 0,
- open_preserve_not_fvar, close_rec_fv, subst_preserve_not_fvar]
+ open_preserve_not_fvar, subst_preserve_not_fvar]
| _ => grind
/-- Closing and opening are inverses. -/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
close_preserve_not_fvartoclose_rec_fv: shorter name, easier to rememberclose_var_not_fvar_rec:close_rec_fvis stronger theoremclose_var_not_fvar: make it preciseclose_rec_fvandclose_var_not_fvarto grindFollowing #580