-
Notifications
You must be signed in to change notification settings - Fork 728
perf: inline dependent instances into specialized decls #10080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zwarich
merged 1 commit into
leanprover:master
from
zwarich:specialization-dependent-instances
Aug 24, 2025
Merged
perf: inline dependent instances into specialized decls #10080
zwarich
merged 1 commit into
leanprover:master
from
zwarich:specialization-dependent-instances
Aug 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit b4f9997. Benchmark Metric Change
===========================================================================================
+ Init.Data.BitVec.Lemmas branches -3.2% (-67.0 σ)
+ Init.Data.BitVec.Lemmas instructions -3.2% (-59.9 σ)
+ Init.Data.List.Sublist async branches -4.1% (-139.0 σ)
+ Init.Data.List.Sublist async instructions -4.1% (-124.3 σ)
+ Init.Prelude async branches -2.2% (-283.6 σ)
+ Init.Prelude async instructions -2.3% (-261.7 σ)
+ Std.Data.DHashMap.Internal.RawLemmas branch-misses -4.9% (-39.5 σ)
+ Std.Data.DHashMap.Internal.RawLemmas branches -2.9% (-172.3 σ)
+ Std.Data.DHashMap.Internal.RawLemmas instructions -3.0% (-155.4 σ)
+ Std.Data.Internal.List.Associative branches -4.0% (-337.8 σ)
+ Std.Data.Internal.List.Associative instructions -4.1% (-298.9 σ)
+ big_do branches -5.4% (-6785.9 σ)
+ big_do instructions -5.6% (-4740.7 σ)
+ big_match branch-misses -2.3% (-23.3 σ)
+ big_match branches -1.2% (-159.1 σ)
+ big_match instructions -1.2% (-131.7 σ)
+ big_omega.lean branches -3.8% (-316.9 σ)
+ big_omega.lean instructions -3.6% (-398.9 σ)
+ big_omega.lean MT branches -3.8% (-212.1 σ)
+ big_omega.lean MT instructions -3.6% (-243.9 σ)
+ bv_decide_inequality.lean task-clock -1.2% (-107.6 σ)
+ bv_decide_mul branches -1.2% (-126.3 σ)
+ bv_decide_mul instructions -1.1% (-90.9 σ)
+ bv_decide_realworld branches -2.2% (-105.9 σ)
+ bv_decide_realworld instructions -2.0% (-86.5 σ)
+ bv_decide_rewriter.lean branch-misses -5.6% (-25.7 σ)
+ bv_decide_rewriter.lean branches -3.4% (-211.0 σ)
+ bv_decide_rewriter.lean instructions -3.6% (-237.6 σ)
+ channel.lean unbounded_seq -1.8%
+ channel.lean unbounded_spsc -2.0% (-117669558323691.0 σ)
+ grind_bitvec2.lean branches -2.3% (-240.2 σ)
+ grind_bitvec2.lean instructions -2.3% (-216.0 σ)
+ grind_list2.lean branches -2.6% (-109.7 σ)
+ grind_list2.lean instructions -2.7% (-99.0 σ)
+ grind_ring_5.lean branches -1.3% (-52.0 σ)
+ grind_ring_5.lean instructions -1.2% (-42.1 σ)
+ iterators branches -19.8% (-9603.1 σ)
+ iterators instructions -16.3% (-8005.5 σ)
+ iterators task-clock -18.4% (-34.4 σ)
+ iterators wall-clock -18.9% (-43.3 σ)
+ lake config elab instructions -2.4% (-86.2 σ)
+ mut_rec_wf branch-misses -2.5% (-20.2 σ)
+ mut_rec_wf branches -1.4% (-162.7 σ)
+ mut_rec_wf instructions -1.3% (-135.6 σ)
+ omega_stress.lean async branches -1.8% (-154.1 σ)
+ omega_stress.lean async instructions -1.7% (-105.5 σ)
+ simp_bubblesort_256 branches -5.6% (-192.1 σ)
+ simp_bubblesort_256 instructions -5.8% (-166.5 σ)
+ simp_local branches -1.8% (-226.9 σ)
+ simp_local instructions -1.9% (-193.7 σ)
+ simp_subexpr branch-misses -6.4% (-88.9 σ)
+ simp_subexpr branches -5.5% (-489.8 σ)
+ simp_subexpr instructions -5.7% (-767.3 σ)
+ stdlib instructions -3.2% (-129.0 σ)
+ stdlib longest rebuild path -2.9% (-46.0 σ)
+ workspaceSymbols with new ranges branches -2.1% (-124.2 σ)
+ workspaceSymbols with new ranges instructions -2.2% (-114.1 σ) |
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
b4f9997 to
b352bee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.