Skip to content

Conversation

@hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Dec 17, 2025

This PR avoids invoking TC synthesis and other inference mechanisms in the simprocs of bv_decide. This can give significant speedups on problems that pressure these simprocs.

@hargoniX
Copy link
Contributor Author

!bench

@leanprover-radar
Copy link

leanprover-radar commented Dec 17, 2025

Benchmark results for 0d8df47 against 118160b are in! @hargoniX

Major changes (1)
  • bv_decide_rewriter.lean//instructions: -831.8M (-4.4%)
Minor changes (2)
  • bv_decide_realworld//instructions: -139.9M (-0.5%)
  • 🟥 channel.lean//instructions: +1.2G (+3.2%)

@hargoniX hargoniX added the changelog-tactics User facing tactics label Dec 17, 2025
@hargoniX hargoniX marked this pull request as ready for review December 17, 2025 11:52
@hargoniX hargoniX added this pull request to the merge queue Dec 17, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 17, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 118160bf07575337957e93232a31b9b1d1a7ac28 --onto 0708024c4649f11da1276d8b6d4345972a9dc57c. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-17 12:09:56)

@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 118160bf07575337957e93232a31b9b1d1a7ac28 --onto 0708024c4649f11da1276d8b6d4345972a9dc57c. You can force reference manual CI using the force-manual-ci label. (2025-12-17 12:09:58)

Merged via the queue into master with commit 3e61514 Dec 17, 2025
26 checks passed
@hargoniX hargoniX deleted the hbv/bv_decide_simproc branch December 17, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-tactics User facing tactics toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants