feat: pre and post may return "done" in Sym.simp
#11900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a `done` flag to the result returned by `Simproc`s in `Sym.simp`.
The `done` flag controls whether simplification should continue after the result:
- `done = false` (default): Continue with subsequent simplification steps
- `done = true`: Stop processing, return this result as final
## Use cases for `done = true`
### In `pre` simprocs
Skip simplification of certain subterms entirely:
```
def skipLambdas : Simproc := fun e =>
if e.isLambda then return .rfl (done := true)
else return .rfl
```
### In `post` simprocs
Perform single-pass normalization without recursive simplification:
```
def singlePassNormalize : Simproc := fun e =>
if let some (e', h) ← tryNormalize e then
return .step e' h (done := true)
else return .rfl
```
With `done = true`, the result `e'` won't be recursively simplified.
## Behavior
The `done` flag affects:
1. **`andThen` composition**: If the first simproc returns `done = true`,
the second simproc is skipped.
2. **Recursive simplification**: After `pre` or `post` returns `.step e' h`,
`simp` normally recurses on `e'`. With `done = true`, recursion is skipped.
The flag is orthogonal to caching: both `.rfl` and `.step` results are cached
regardless of the `done` flag, and cached results are always treated as final.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
doneflag to the result returned bySimprocs inSym.simp.The
doneflag controls whether simplification should continue after the result:done = false(default): Continue with subsequent simplification stepsdone = true: Stop processing, return this result as finalUse cases for
done = trueIn
presimprocsSkip simplification of certain subterms entirely:
In
postsimprocsPerform single-pass normalization without recursive simplification:
With
done = true, the resulte'won't be recursively simplified.