refactor: add message log capture helpers for tactic evaluation #11933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds utility functions for managing the message log during tactic evaluation, and refactors existing code to use them. New helpers in `Lean.Elab.Tactic`: - `withSuppressedMessages`: executes an action while suppressing new messages - `withCapturedMessages`: executes an action and returns any new messages - `hasErrorMessages`: checks if a message list contains errors Refactored to use these helpers: - `LibrarySearch.tryDischarger`: now uses `withSuppressedMessages` - `Try.evalAndSuggest`: now uses `withSuppressedMessages` - `Try.evalAndSuggestWithBy`: now uses `withSuppressedMessages` Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds utility functions for managing the message log during tactic
evaluation, and refactors existing code to use them.
New helpers in
Lean.Elab.Tactic:withSuppressedMessages: executes an action while suppressing new messageswithCapturedMessages: executes an action and returns any new messageshasErrorMessages: checks if a message list contains errorsRefactored to use these helpers:
LibrarySearch.tryDischarger: now useswithSuppressedMessagesTry.evalAndSuggest: now useswithSuppressedMessagesTry.evalAndSuggestWithBy: now useswithSuppressedMessagesThese helpers provide a standard pattern for tactic validation that needs to
inspect error messages (e.g., filtering out suggestions that produce errors).
🤖 Prepared with Claude Code