perf: normalize levels after instantiateMVars#12225
Draft
JovanGerb wants to merge 3 commits intoleanprover:masterfrom
Draft
perf: normalize levels after instantiateMVars#12225JovanGerb wants to merge 3 commits intoleanprover:masterfrom
instantiateMVars#12225JovanGerb wants to merge 3 commits intoleanprover:masterfrom
Conversation
Contributor
Author
|
!bench mathlib |
|
Benchmark results for leanprover-community/mathlib4-nightly-testing@f62f69d against leanprover-community/mathlib4-nightly-testing@e0bf30b are in! @JovanGerb
No significant changes detected. |
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 29, 2026
github-actions
bot
added
the
mathlib4-nightly-available
ghost
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 29, 2026
ghost
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 29, 2026
ghost
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 29, 2026
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 29, 2026
ghost
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 29, 2026
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 30, 2026
This PR fixes some linter warnings that came up on the adaptation branch of leanprover/lean4#12225. - Removed some unused `simp` arguments - Removed some uses of `change` that didn't do anything
YellPika
pushed a commit
to YellPika/mathlib4
that referenced
this pull request
Feb 3, 2026
…ty#34591) This PR fixes some linter warnings that came up on the adaptation branch of leanprover/lean4#12225. - Removed some unused `simp` arguments - Removed some uses of `change` that didn't do anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address the kernel normalization issue reported by Kevin Buzzard at https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/kernel.20universe.20normalization.20issue/with/570436294.
The current implementation is not too efficient - it would be better to call
Level.normalizestraight from the c++. But the current version is a very small change, and easy to test.