fix: remove withDefault footgun from assignOutParams#12488
Draft
fix: remove withDefault footgun from assignOutParams#12488
Conversation
This reverts part of the `OrderDual` workaround from #12286. `withDefault` at the `isDefEq` in `assignOutParams` is a potential performance footgun: TC resolution is supposed to unfold only `reducible` and `instance_reducible` declarations. The `withDefault` was added back because `OrderDual` (a semireducible type alias) triggered thousands of Mathlib failures without it. This is an experimental branch for testing whether Mathlib's `OrderDual` refactoring has progressed enough to remove this workaround.
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
withDefaultfrom theisDefEqcall inassignOutParams, reverting one of the workarounds from #12286 that was temporarily introduced for Mathlib compatibility. (See #12489 for the other.)withDefaultat thisisDefEqis a potential performance footgun: TC resolution is supposed to unfold only[reducible]and[instance_reducible]declarations. ThewithDefaultwas added back in #12286 becauseOrderDual(a semireducible type aliasdef OrderDual (α : Type) : Type := α) triggered thousands of Mathlib failures without it.This is an experimental branch for testing changes to Mathlib.
🤖 Prepared with Claude Code