fix: withNamespace now correctly calls popScopes after running#12647
Merged
wkrozowski merged 1 commit intoleanprover:masterfrom Feb 24, 2026
Merged
fix: withNamespace now correctly calls popScopes after running#12647wkrozowski merged 1 commit intoleanprover:masterfrom
withNamespace now correctly calls popScopes after running#12647wkrozowski merged 1 commit intoleanprover:masterfrom
Conversation
This PR adds the missing `popScopes` call to `withNamespace`, which previously only dropped scopes from the elaborator's `Command.State` but did not pop the environment's `ScopedEnvExtension` state stacks. This caused scoped syntax declarations to leak keywords outside their namespace when `withNamespace` had been called. Closes leanprover#12630 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
popScopescall towithNamespace, which previouslyonly dropped scopes from the elaborator's
Command.Statebut did not pop theenvironment's
ScopedEnvExtensionstate stacks. This caused scoped syntaxdeclarations to leak keywords outside their namespace when
withNamespacehadbeen called.
Closes #12630