refactor: port simple ground expr extraction from IR to LCNF#12705
Merged
refactor: port simple ground expr extraction from IR to LCNF#12705
Conversation
Contributor
Author
|
!bench |
|
Benchmark results for 3f65b0d against 846420d are in! @hargoniX
Small changes (1✅)
|
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
sgraf812
pushed a commit
that referenced
this pull request
Feb 26, 2026
This PR ports the simple ground expression extraction pass from IR to LCNF. I locally confirmed that this produces no diff between stage1/stage2 at the C level (apart from the changed compiler files) so this should essentially be binary equivalent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the simple ground expression extraction pass from IR to LCNF.
I locally confirmed that this produces no diff between stage1/stage2 at the C level (apart from the
changed compiler files) so this should essentially be binary equivalent.