perf: non quadratic closed term initialization for closed array literals#12715
Merged
perf: non quadratic closed term initialization for closed array literals#12715
Conversation
Contributor
Author
|
!bench |
|
Benchmark results for a90890b against adf3e5e are in! @hargoniX
Large changes (1✅)
Small changes (17✅, 1🟥)
|
a90890b to
adde160
Compare
Contributor
Author
|
!bench |
|
Benchmark results for adde160 against 738688e are in! @hargoniX
Large changes (1✅)
Medium changes (1🟥)
Small changes (21✅, 3🟥) Too many entries to display here. View the full report on radar instead. |
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the compiler extracts
Array/ByteArray/FloatArrayliterals as one big closed term to avoid quadratic overhead at closed term initialization time.