feat: add short-circuit evaluation for Or and And in cbv#12763
Merged
wkrozowski merged 1 commit intoleanprover:masterfrom Mar 2, 2026
Merged
feat: add short-circuit evaluation for Or and And in cbv#12763wkrozowski merged 1 commit intoleanprover:masterfrom
Or and And in cbv#12763wkrozowski merged 1 commit intoleanprover:masterfrom
Conversation
This PR adds pre-pass simprocs `simpOr` and `simpAnd` to the `cbv` tactic that evaluate only the left argument of `Or`/`And` first, short-circuiting when the result is determined without evaluating the right side. Previously, `cbv` processed `Or`/`And` via congruence, which always evaluated both arguments. For expressions like `decide (m < n ∨ expensive)`, when `m < n` is true, the expensive right side is now skipped entirely. This avoids exponential blowup in proof term size for examples like Collatz conjecture verification. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
!bench |
|
Benchmark results for f41a502 against 292b423 are in! @wkrozowski
Large changes (1✅)
Small changes (2🟥)
|
Or and And in cbv
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds pre-pass simprocs
simpOrandsimpAndto thecbvtactic that evaluate only the left argument ofOr/Andfirst, short-circuiting when the result is determined without evaluating the right side. Previously,cbvprocessedOr/Andvia congruence, which always evaluated both arguments. For expressions likedecide (m < n ∨ expensive), whenm < nis true, the expensive right side is now skipped entirely.🤖 Generated with Claude Code