feat: add cbv at location syntax#12773
Merged
wkrozowski merged 7 commits intoleanprover:masterfrom Mar 3, 2026
Merged
Conversation
Extract cbvCore as a SymM action and use it with preprocessMVar in cbvGoal so all hypotheses and the target share a single SymM context. Deduplicate evalCbv location handling and update cbvDecideGoal to use cbvCore. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
!bench |
|
Benchmark results for 19bc692 against 03a5db3 are in! @wkrozowski Warning These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.
Medium changes (1✅)
Small changes (1✅, 2🟥)
|
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Contributor
Author
|
!bench |
|
Benchmark results for b46b95a against 1f04bf4 are in! @wkrozowski
Medium changes (1✅)
Small changes (2🟥)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
atlocation syntax to thecbvtactic, matching the interface ofsimp at. Previouslycbvcould only reduce the goal target; now it supportscbv at h,cbv at h |-, andcbv at *.cbvGoalis rewritten to useSym.preprocessMVarfollowed bycbvCorewithin a singleSymMcontext, sharing the term table across all hypotheses and the target. The oldcbvGoalCore(which reduced one side of an equation goal at a time) is replaced by a general approach that reduces arbitrary goal types and hypothesis types, with special handling forTruetargets andFalsehypotheses.cbvDecideGoalis updated to use the extractedcbvCoreas well.🤖 Generated with Claude Code