fix: preserve @[implicit_reducible] for WF-recursive definitions#12776
Merged
fix: preserve @[implicit_reducible] for WF-recursive definitions#12776
@[implicit_reducible] for WF-recursive definitions#12776Conversation
Co-authored-by: nomeata <148037+nomeata@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix reducibility special handling in wfrec for instance_reproducible
Fix Mar 3, 2026
@[instance_reducible] not being preserved for WF-recursive definitions
Collaborator
|
@copilot looks good. Please reformat PR title and description according to the commit convention. |
Contributor
Author
Updated the PR description to follow the commit convention. The PR title should be updated to: |
Copilot
AI
changed the title
Fix
fix: preserve Mar 3, 2026
@[instance_reducible] not being preserved for WF-recursive definitions@[instance_reducible] for WF-recursive definitions
Contributor
|
The new preferred name is |
@[instance_reducible] for WF-recursive definitions@[implicit_reducible] for WF-recursive definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
@[implicit_reducible]on well-founded recursive definitions.addPreDefAttributessets WF-recursive definitions as@[irreducible]by default, skipping this only when the user explicitly wrote@[reducible]or@[semireducible]. It was missing@[instance_reducible]and@[implicit_reducible], causing those attributes to be silently overridden.Add
instance_reducibleandimplicit_reducibleto the check insrc/Lean/Elab/PreDefinition/Mutual.leanthat guards against overriding user-specified reducibility attributes, and add regression tests intests/elab/wfirred.lean.Example
Fixes #12775