Skip to content

refactor: reduce duplication in string pattern lemmas#12793

Merged
TwoFX merged 11 commits intoleanprover:masterfrom
TwoFX:string-lemma-refactor
Mar 4, 2026
Merged

refactor: reduce duplication in string pattern lemmas#12793
TwoFX merged 11 commits intoleanprover:masterfrom
TwoFX:string-lemma-refactor

Conversation

@TwoFX
Copy link
Copy Markdown
Member

@TwoFX TwoFX commented Mar 4, 2026

This PR takes a more principled approach in deriving String pattern lemmas by reducing to simpler cases similar to how the instances are defined.

This reduces duplication of complex arguments (at the expense of having to state more simple lemmas; however these lemmas are useful to users as well).

@TwoFX TwoFX requested a review from kim-em as a code owner March 4, 2026 16:56
@TwoFX TwoFX added the changelog-library Library label Mar 4, 2026
@TwoFX TwoFX enabled auto-merge March 4, 2026 17:41
@TwoFX TwoFX added this pull request to the merge queue Mar 4, 2026
Merged via the queue into leanprover:master with commit 10ece4e Mar 4, 2026
15 checks passed
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 4, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 59711e5cff9327526391097f7536587676e25b01 --onto cda84702e9b31165f1f83c657b532f36f34e0bd0. You can force Mathlib CI using the force-mathlib-ci label. (2026-03-04 18:35:59)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 59711e5cff9327526391097f7536587676e25b01 --onto cda84702e9b31165f1f83c657b532f36f34e0bd0. You can force reference manual CI using the force-manual-ci label. (2026-03-04 18:36:01)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants