Skip to content

feat: make the borrow inference explain itself#12810

Merged
hargoniX merged 1 commit intomasterfrom
hbv/lcnf_explain_infer_borrow
Mar 5, 2026
Merged

feat: make the borrow inference explain itself#12810
hargoniX merged 1 commit intomasterfrom
hbv/lcnf_explain_infer_borrow

Conversation

@hargoniX
Copy link
Copy Markdown
Contributor

@hargoniX hargoniX commented Mar 5, 2026

This PR adds tracing to the borrow inference to explain to the user why it got to its conclusions.

@hargoniX hargoniX requested a review from leodemoura as a code owner March 5, 2026 13:12
@hargoniX
Copy link
Copy Markdown
Contributor Author

hargoniX commented Mar 5, 2026

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Mar 5, 2026

Benchmark results for 65fcbae against 8d42ad4 are in! @hargoniX

  • 🟥 build//instructions: +996.1M (+0.01%)

Small changes (3🟥)

  • 🟥 build/module/Lean.Compiler.LCNF.InferBorrow//instructions: +1.0G (+18.08%) (reduced significance based on *//lines)
  • 🟥 build/module/Lean.Compiler.LCNF.Main//instructions: +73.1M (+1.58%) (reduced significance based on *//lines)
  • 🟥 build/module/Lean.Compiler.Options//instructions: +19.7M (+3.60%)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 5, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 8d42ad47968312034f9a8acb7cd8d650d270cada --onto 333ab1c6f0ce11f33551d6a736054cb72812cad9. You can force Mathlib CI using the force-mathlib-ci label. (2026-03-05 14:03:15)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 8d42ad47968312034f9a8acb7cd8d650d270cada --onto cda84702e9b31165f1f83c657b532f36f34e0bd0. You can force reference manual CI using the force-manual-ci label. (2026-03-05 14:03:16)

@hargoniX hargoniX added the changelog-compiler Compiler, runtime, and FFI label Mar 5, 2026
@hargoniX hargoniX added this pull request to the merge queue Mar 5, 2026
Merged via the queue into master with commit a34777a Mar 5, 2026
22 of 23 checks passed
@hargoniX hargoniX deleted the hbv/lcnf_explain_infer_borrow branch March 5, 2026 14:50
sgraf812 pushed a commit that referenced this pull request Mar 9, 2026
This PR adds tracing to the borrow inference to explain to the user why
it got to its conclusions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-compiler Compiler, runtime, and FFI toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants