feat: allow erasing cbv_eval attributes#12851
Merged
wkrozowski merged 1 commit intoleanprover:masterfrom Mar 10, 2026
Merged
Conversation
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add support for erasing
@[cbv_eval]annotations usingattribute [-cbv_eval], mirroring the existing@[-simp]mechanism for simp lemmas.The
CbvEvalEntrynow tracks the original declaration name (origin) so that inverted theorems (@[cbv_eval ←]) can be erased by their original name. TheCbvEvalStatestores individual entries alongside the composedTheoremsdiscrimination tree, allowing the tree to be rebuilt from remaining entries after erasure. Erasure is properly scoped viamodifyState, soattribute [-cbv_eval]inside asectionis reverted when the section ends.🤖 Generated with Claude Code