Skip to content

fix: remove use of native_decide in the HTTP library#12857

Merged
algebraic-dev merged 8 commits intomasterfrom
sofia/fix-native-decide
Mar 10, 2026
Merged

fix: remove use of native_decide in the HTTP library#12857
algebraic-dev merged 8 commits intomasterfrom
sofia/fix-native-decide

Conversation

@algebraic-dev
Copy link
Copy Markdown
Member

This PR removes the use of native_decide in the HTTP library and adds proofs to remove the panic!.

@algebraic-dev algebraic-dev changed the title fix: remove use of native_decide in the HTTP library. fix: remove use of native_decide in the HTTP library Mar 9, 2026
@algebraic-dev algebraic-dev requested a review from nomeata March 9, 2026 19:25
Comment thread src/Std/Internal/Http/Data/Chunk.lean Outdated
@algebraic-dev algebraic-dev force-pushed the sofia/fix-native-decide branch from 15ba155 to 1fa01cd Compare March 10, 2026 00:02
@algebraic-dev algebraic-dev marked this pull request as ready for review March 10, 2026 00:58
@algebraic-dev algebraic-dev requested a review from TwoFX as a code owner March 10, 2026 00:58
@algebraic-dev algebraic-dev requested a review from nomeata March 10, 2026 00:58
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 10, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing bot commented Mar 10, 2026

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 71ff36621103dfab119dfbead39dea3995d5832d --onto 333ab1c6f0ce11f33551d6a736054cb72812cad9. You can force Mathlib CI using the force-mathlib-ci label. (2026-03-10 01:07:08)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 71ff36621103dfab119dfbead39dea3995d5832d --onto e8048291010c815d0d30926924e7ad7afc18b1c0. You can force Mathlib CI using the force-mathlib-ci label. (2026-03-10 13:53:19)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 71ff36621103dfab119dfbead39dea3995d5832d --onto a165292462a973c20d3cc8c8b23a3ac2334a2a4a. You can force reference manual CI using the force-manual-ci label. (2026-03-10 01:07:09)

Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor nitpicks.

Comment thread src/Std/Internal/Http/Internal/Char.lean Outdated
Comment thread src/Std/Internal/Http/Internal/Char.lean Outdated
@algebraic-dev algebraic-dev enabled auto-merge March 10, 2026 13:09
@algebraic-dev algebraic-dev added this pull request to the merge queue Mar 10, 2026
Merged via the queue into master with commit e9060e7 Mar 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants