fix: remove use of native_decide in the HTTP library#12857
Merged
algebraic-dev merged 8 commits intomasterfrom Mar 10, 2026
Merged
fix: remove use of native_decide in the HTTP library#12857algebraic-dev merged 8 commits intomasterfrom
native_decide in the HTTP library#12857algebraic-dev merged 8 commits intomasterfrom
Conversation
native_decide in the HTTP library.native_decide in the HTTP library
nomeata
reviewed
Mar 9, 2026
15ba155 to
1fa01cd
Compare
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
TwoFX
approved these changes
Mar 10, 2026
Member
TwoFX
left a comment
There was a problem hiding this comment.
Looks good, just some minor nitpicks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
native_decidein the HTTP library and adds proofs to remove thepanic!.