feat: support expected type annotation in doPatDecl#12866
Merged
Conversation
This PR allows `let ⟨width, height⟩ : Nat × Nat ← action` in do-notation, propagating the expected type to the monadic action. Previously, only `let ⟨width, height⟩ : Nat × Nat := ← action` was supported, requiring the less ergonomic `:= ←` workaround. The type annotation is added as `optType` in the `doPatDecl` parser, matching `doIdDecl`'s existing support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
optTypesupport to thedoPatDeclparser, allowinglet ⟨width, height⟩ : Nat × Nat ← actionin do-notation. Previously, onlythe less ergonomic
let ⟨width, height⟩ : Nat × Nat := ← actionworkaroundwas available. The type annotation is propagated to the monadic action as an
expected type, matching
doIdDecl's existing behavior.Both the legacy and new (BuiltinDo) elaborators are updated.