Skip to content

chore: do not use internal append in ToString instances for basic types#12885

Merged
TwoFX merged 1 commit intoleanprover:masterfrom
TwoFX:int-repr
Mar 11, 2026
Merged

chore: do not use internal append in ToString instances for basic types#12885
TwoFX merged 1 commit intoleanprover:masterfrom
TwoFX:int-repr

Conversation

@TwoFX
Copy link
Copy Markdown
Member

@TwoFX TwoFX commented Mar 11, 2026

This PR shifts some material in Init to make sure that the ToString instances of basic types don't rely on String.Internal.append.

@TwoFX TwoFX added the changelog-library Library label Mar 11, 2026
@TwoFX TwoFX marked this pull request as ready for review March 11, 2026 15:24
@TwoFX TwoFX requested review from datokrat and kim-em as code owners March 11, 2026 15:24
@TwoFX TwoFX changed the title chore: do not use String.Internal.append in ToString instances for List, Array, Int, etc. chore: do not use internal append in ToString instances for basic types Mar 11, 2026
@TwoFX TwoFX added this pull request to the merge queue Mar 11, 2026
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 11, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a32be44f909683a2f5dff4bb955dfa986bbc9b1c --onto e8048291010c815d0d30926924e7ad7afc18b1c0. You can force Mathlib CI using the force-mathlib-ci label. (2026-03-11 15:33:44)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase a32be44f909683a2f5dff4bb955dfa986bbc9b1c --onto ff6816a854ef5cf2966519452d03933785f2fdeb. You can force reference manual CI using the force-manual-ci label. (2026-03-11 15:33:46)

Merged via the queue into leanprover:master with commit 4deb8d5 Mar 11, 2026
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants