Skip to content

feat: option to ignore borrowing annotations completely#12886

Merged
hargoniX merged 1 commit intomasterfrom
hbv/lcnf_ignore_annotations
Mar 11, 2026
Merged

feat: option to ignore borrowing annotations completely#12886
hargoniX merged 1 commit intomasterfrom
hbv/lcnf_ignore_annotations

Conversation

@hargoniX
Copy link
Copy Markdown
Contributor

This PR adds support for ignoring user defined borrow annotations. This can be useful when defining
extern/export pairs as the extern might be infected by borrow annotations while in export
they are already ignored.

@hargoniX hargoniX requested a review from leodemoura as a code owner March 11, 2026 15:47
@hargoniX
Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Mar 11, 2026

Benchmark results for d62c43a against d3db436 are in. There are no significant changes. @hargoniX

  • 🟥 build//instructions: +773.8M (+0.01%)

Small changes (4🟥)

  • 🟥 build/module/Lean.Compiler.IR.AddExtern//instructions: +32.4M (+3.11%) (reduced significance based on *//lines)
  • 🟥 build/module/Lean.Compiler.LCNF.ToDecl//instructions: +141.4M (+3.69%) (reduced significance based on *//lines)
  • 🟥 build/module/Lean.Compiler.Options//instructions: +20.2M (+3.55%)
  • 🟥 elab/simp_bubblesort_256//wall-clock: +32ms (+3.28%)

@hargoniX hargoniX added the changelog-compiler Compiler, runtime, and FFI label Mar 11, 2026
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 11, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d3db4368d499ae0933d253e4771cc187b592e577 --onto e8048291010c815d0d30926924e7ad7afc18b1c0. You can force Mathlib CI using the force-mathlib-ci label. (2026-03-11 16:57:18)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase d3db4368d499ae0933d253e4771cc187b592e577 --onto ff6816a854ef5cf2966519452d03933785f2fdeb. You can force reference manual CI using the force-manual-ci label. (2026-03-11 16:57:21)

@hargoniX hargoniX added this pull request to the merge queue Mar 11, 2026
Merged via the queue into master with commit d9ebd51 Mar 11, 2026
22 of 23 checks passed
@hargoniX hargoniX deleted the hbv/lcnf_ignore_annotations branch March 11, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-compiler Compiler, runtime, and FFI toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants