Skip to content

feat: add String simprocs to cbv#12888

Merged
wkrozowski merged 1 commit intoleanprover:masterfrom
wkrozowski:wojciech/string_simprocs
Mar 12, 2026
Merged

feat: add String simprocs to cbv#12888
wkrozowski merged 1 commit intoleanprover:masterfrom
wkrozowski:wojciech/string_simprocs

Conversation

@wkrozowski
Copy link
Copy Markdown
Contributor

This PR adds String-specific simprocs to cbv tactic.

@wkrozowski wkrozowski added the changelog-tactics User facing tactics label Mar 11, 2026
@wkrozowski
Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Mar 11, 2026

Benchmark results for 4d4b0cc against a32be44 are in. There are no significant changes. @wkrozowski

  • 🟥 build//instructions: +1.3G (+0.01%)

Medium changes (1🟥)

  • 🟥 compiled/workspaceSymbolsNewRanges//instructions: +16.1M (+2.17%)

Small changes (1🟥)

  • 🟥 build/module/Lean.Meta.Tactic.Cbv.Util//instructions: +91.4M (+7.34%) (reduced significance based on *//lines)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 11, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a32be44f909683a2f5dff4bb955dfa986bbc9b1c --onto e8048291010c815d0d30926924e7ad7afc18b1c0. You can force Mathlib CI using the force-mathlib-ci label. (2026-03-11 17:04:41)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase a32be44f909683a2f5dff4bb955dfa986bbc9b1c --onto ff6816a854ef5cf2966519452d03933785f2fdeb. You can force reference manual CI using the force-manual-ci label. (2026-03-11 17:04:43)

@wkrozowski wkrozowski marked this pull request as ready for review March 12, 2026 11:51
@wkrozowski wkrozowski requested a review from leodemoura as a code owner March 12, 2026 11:51
@wkrozowski wkrozowski added this pull request to the merge queue Mar 12, 2026
Merged via the queue into leanprover:master with commit 4783372 Mar 12, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-tactics User facing tactics toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants